On Fri, Sep 28, 2012 at 10:08:34AM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 28, 2012 at 02:23:51PM +0200, Joerg Roedel wrote: > > + if (type != 1 && type != 2) > > + return -EINVAL; > > Should this be perhaps an enum? or #define?
Yup, that'll be better. I change it. > Reviwed-by: Konrad Rzeszutek Wilk <[email protected]> Thanks! Joerg -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
