On Mon, 04 Feb 2013 15:41:24 -0700
Alex Williamson <[email protected]> wrote:

> +
> +     if (pci_is_pcie(parent) &&
> +         (pci_pcie_type(parent) == PCI_EXP_TYPE_ROOT_PORT ||
> +          pci_pcie_type(parent) == PCI_EXP_TYPE_DOWNSTREAM)) {
> +             pr_warn("WARNING: Your hardware is broken, device %s appears to 
> be a\n Legacy PCI device attached directly to a PCIe device which is not a\n 
> PCIe-to-PCI bridge.  Per section 7.8 of the PCI Express 3.0 spec, the\n PCI 
> express capability structure is required for PCI express 
> device\nfunctions.\n",
> +                     pci_name(pdev));

Too whiny!
Two short lines seems to be more the enough. Users can't do anything about
hardware not following spec. Put any outher stuff into comments.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to