On Fri, Dec 6, 2013 at 11:21 AM, Jiang Liu <[email protected]>wrote:
> Flag irq_remapping_enabled is only set by intel_enable_irq_remapping(), > which is called after detect_intel_iommu(). So we should check flag > disable_irq_remap instead of irq_remapping_enabled in function > detect_intel_iommu(). > > Reviewed-by: Yijing Wang <[email protected]> > Signed-off-by: Jiang Liu <[email protected]> > --- > drivers/iommu/dmar.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c > index c17dbf7..70612a9 100644 > --- a/drivers/iommu/dmar.c > +++ b/drivers/iommu/dmar.c > @@ -560,7 +560,7 @@ int __init detect_intel_iommu(void) > > dmar = (struct acpi_table_dmar *) dmar_tbl; > > - if (ret && irq_remapping_enabled && cpu_has_x2apic && > + if (ret && !disable_irq_remap && cpu_has_x2apic && > dmar->flags & 0x1) > pr_info("Queued invalidation will be enabled to > support x2apic and Intr-remapping.\n"); > Then is it better to move this pr_info code to intel_enable_irq_remapping? > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html >
_______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
