On Fri, 14 Mar 2014 17:29:36 +0530, Sachin Kamat wrote: > On 14 March 2014 17:19, Cho KyongHo <pullip....@samsung.com> wrote: > >> From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > >> Sent: Friday, March 14, 2014 7:00 PM > >> > >> On 14 March 2014 10:31, Cho KyongHo <pullip....@samsung.com> wrote: > >> > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from > >> > exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without > >> > removing remaining use of it from exynos-iommu driver, thus causing a > >> > compilation error. > >> > > >> > This patch fixes the error by removing respective include line > >> > from exynos-iommu.c. > >> > > >> > CC: Tomasz Figa <t.f...@samsung.com> > >> > Signed-off-by: Cho KyongHo <pullip....@samsung.com> > >> > --- > >> > drivers/iommu/exynos-iommu.c | 3 +-- > >> > 1 file changed, 1 insertion(+), 2 deletions(-) > >> > > >> > diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c > >> > index 0740189..4876d35 100644 > >> > --- a/drivers/iommu/exynos-iommu.c > >> > +++ b/drivers/iommu/exynos-iommu.c > >> > @@ -12,6 +12,7 @@ > >> > #define DEBUG > >> > #endif > >> > > >> > +#include <linux/kernel.h> > >> > >> This change doesn't look related to the patch subject/description. > >> > > Yes. But it is simply added without any side-effect. > > Do you think it should be in a separate patch?. > > Actually, the added line is a redundant. > > If it is redundant, then you shouldn't be adding it. If it is > required, then please > mention about the need in the commit description if not a separate patch. >
Ok. Thanks for the advice. KyongHo _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
