Hi Emil, Thanks for pointing this out. Please find my comment inline. Regards Varun
> -----Original Message----- > From: Emil Medve [mailto:emilian.me...@freescale.com] > Sent: Thursday, January 22, 2015 3:36 AM > To: iommu@lists.linux-foundation.org; j...@8bytes.org; jroe...@suse.de; > Sethi Varun-B16395 > Cc: Medve Emilian-EMMEDVE1 > Subject: [PATCH] iommu/fsl: Fix section mismatch > > Section mismatch in reference from the variable fsl_of_pamu_driver to the > function .init.text:fsl_pamu_probe() The variable fsl_of_pamu_driver > references the function __init fsl_pamu_probe() If the reference is valid > then annotate the variable with __init* or __refdata (see linux/init.h) or > name the variable: > *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console > > Signed-off-by: Emil Medve <emilian.me...@freescale.com> > --- > drivers/iommu/fsl_pamu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c index > 80ac68d..076a951 100644 > --- a/drivers/iommu/fsl_pamu.c > +++ b/drivers/iommu/fsl_pamu.c > @@ -1016,7 +1016,7 @@ static const struct { > > #define SVR_SECURITY 0x80000 /* The Security (E) bit */ > > -static int __init fsl_pamu_probe(struct platform_device *pdev) > +static int fsl_pamu_probe(struct platform_device *pdev) > { > void __iomem *pamu_regs = NULL; > struct ccsr_guts __iomem *guts_regs = NULL; > -- > 2.2.2 Fsl_pamu_probe is expected to be called during system initialization in order to initialize PAMU before other devices are initialized. We should make fsl_of_pamu_driver as __initdata. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
