On Wed, Apr 01, 2015 at 02:52:57PM +0100, David Woodhouse wrote: > On Wed, 2015-04-01 at 14:39 +0100, Will Deacon wrote: > > We'd also need to update any page-table code that relies on being called > > one page at a time (i.e. the new io-pgtable stuff we merged for 4.0) so > > that we iterate over the requested range. > > Ick. I hadn't noticed we'd entrenched that mistake even harder. It > certainly *wasn't* that hard to fix it...
Well, at least it's now in one place! (before, the same mistake was in each driver). > > That shouldn't be too difficult (i.e. just inline the iommu_map logic > > into each driver), but it would need some testing. > > Good. > > > In fact, that would also allow us to nuke the whole TLB on VFIO unmap of > > large ranges. We currently iterate over the range page-by-page, which takes > > ages (minutes) in simulation. > > Which is one of the big reasons we lie about page sizes in VT-d. Makes sense for now. That just leaves the case where the caller tries to map something smaller than a page. Do we want to return the amount mapped in iommu_map? Will _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
