On 2015/6/30 1:26, Will Deacon wrote: > On Fri, Jun 26, 2015 at 09:33:00AM +0100, Zhen Lei wrote: >> Now we only use TT0 translation, disable TT1 translation will safer. >> >> Signed-off-by: Zhen Lei <[email protected]> >> --- >> drivers/iommu/arm-smmu-v3.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c >> index 43120ad..6d6712e 100644 >> --- a/drivers/iommu/arm-smmu-v3.c >> +++ b/drivers/iommu/arm-smmu-v3.c >> @@ -285,6 +285,7 @@ >> #define ARM64_TCR_EPD1_MASK 0x1UL >> >> #define CTXDESC_CD_0_ENDI (1UL << 15) >> +#define CTXDESC_CD_0_EPD1 (1UL << 30) >> #define CTXDESC_CD_0_V (1UL << 31) >> >> #define CTXDESC_CD_0_TCR_IPS_SHIFT 32 >> @@ -893,7 +894,7 @@ static void arm_smmu_write_ctx_desc(struct >> arm_smmu_device *smmu, >> #endif >> CTXDESC_CD_0_R | CTXDESC_CD_0_A | CTXDESC_CD_0_ASET_PRIVATE | >> CTXDESC_CD_0_AA64 | (u64)cfg->cd.asid << CTXDESC_CD_0_ASID_SHIFT | >> - CTXDESC_CD_0_V; >> + CTXDESC_CD_0_EPD1 | CTXDESC_CD_0_V; > > > This is redundant. EPD1 is already set by the io-pgtable code.
OK, I will drop this patch. I made a mistake. > > Will > > . > _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
