On Thu, 2015-10-15 at 21:25 +0300, Dan Carpenter wrote:
> The "req->addr" variable is a bit field declared as "u64 addr:52;".
> The "address" variable is a u64. We need to cast "req->addr" to a u64
> before the shift or the result is truncated to 52 bits.
>
> Fixes: 0b9252a34858 ('iommu/vt-d: Implement page request handling')
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>Applied; thanks. > Also does this code work if PAGE_SHIFT is more than 12? (I am a newbie > so this is not rhetorical, I don't know the answer). Er, no it doesn't. That should have been VTD_PAGE_SHIFT, not PAGE_SHIFT — and then it *will* always be 12. Thanks for pointing it out. -- David Woodhouse Open Source Technology Centre david.woodho...@intel.com Intel Corporation
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
