Hi Magnus,

On Tue, Dec 15, 2015 at 2:05 PM, Magnus Damm <[email protected]> wrote:
> From: Magnus Damm <[email protected]>
>
> Introduce struct ipmmu_features to track various hardware
> and software implementation changes inside the driver for
> various kinds of IPMMU hardware. Add use_ns_alias_offset
> as a first example of a feature to control if the secure
> register bank offset should be used or not.
>
> Signed-off-by: Magnus Damm <[email protected]>
> ---
>
>  drivers/iommu/ipmmu-vmsa.c |   34 ++++++++++++++++++++++++++++------
>  1 file changed, 28 insertions(+), 6 deletions(-)
>
> --- 0009/drivers/iommu/ipmmu-vmsa.c
> +++ work/drivers/iommu/ipmmu-vmsa.c     2015-12-15 13:41:22.600513000 +0900
> @@ -31,6 +31,10 @@
>
>  #define IPMMU_CTX_MAX 1
>
> +struct ipmmu_features {
> +       bool use_ns_alias_offset;
> +};

Given you're adding more than 4 features in this series, you may want to
consider using an unsigned int bitfield instead.

That way you could also store it directly in of_device_id.data, if you want.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to