On 12/07/16 02:33, Peng Fan wrote: > There is no need to call devm_free_irq when driver detach. > devres_release_all which is called after 'drv->remove' will > release all managed resources. > > Signed-off-by: Peng Fan <van.free...@gmail.com> > Cc: Will Deacon <will.dea...@arm.com> > Cc: Robin Murphy <robin.mur...@arm.com>
drivers/iommu/arm-smmu.c: In function 'arm_smmu_device_remove': drivers/iommu/arm-smmu.c:2021:6: warning: unused variable 'i' [-Wunused-variable] int i; ^ With that addressed: Reviewed-by: Robin Murphy <robin.mur...@arm.com> > --- > drivers/iommu/arm-smmu.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index 860652e..5837391c 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -2045,9 +2045,6 @@ static int arm_smmu_device_remove(struct > platform_device *pdev) > if (!bitmap_empty(smmu->context_map, ARM_SMMU_MAX_CBS)) > dev_err(dev, "removing device with active domains!\n"); > > - for (i = 0; i < smmu->num_global_irqs; ++i) > - devm_free_irq(smmu->dev, smmu->irqs[i], smmu); > - > /* Turn the thing off */ > writel(sCR0_CLIENTPD, ARM_SMMU_GR0_NS(smmu) + ARM_SMMU_GR0_sCR0); > return 0; > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu