On 09/08/16 16:01, Joerg Roedel wrote: > On Wed, Jul 27, 2016 at 04:46:06PM +0100, Robin Murphy wrote: >> Due to the limitations of having to wait until we see a device's DMA >> restrictions before we know how we want an IOVA domain initialised, >> there is a window for error if a DMA ops domain is allocated but later >> freed without ever being used. In that case, init_iova_domain() was >> never called, so calling put_iova_domain() from iommu_put_dma_cookie() >> ends up trying to take an uninitialised lock and crashing. >> >> Make things robust by skipping the call unless the IOVA domain actually >> has been initialised, as we probably should have done from the start. >> > > Missing 'Fixes:' and probably 'Cc: stable' lines? > >> Reported-by: Nate Watterson <[email protected]> >> Signed-off-by: Robin Murphy <[email protected]> >> --- >> >> I'm not sure this warrants a cc stable, as with the code currently in >> mainline it's only at all likely if other things have already failed >> elsewhere in a manner they should not be expected to. > > Yes, I think this qualifies for stable. Please re-send with the Acks and > Reviewed-by lines too. I'll queue this in my fixes branch and send it > upstream asap.
Will do, thanks! Robin. > > > Joerg > _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
