Hi,
On 09/03/2017 20:50, Robin Murphy wrote:
> Even if a host controller's CPU-side MMIO windows into PCI I/O space do
> happen to leak into PCI memory space such that it might treat them as
> peer addresses, trying to reserve the corresponding I/O space addresses
> doesn't do anything to help solve that problem. Stop doing a silly thing.
>
> Fixes: fade1ec055dc ("iommu/dma: Avoid PCI host bridge windows")
> Signed-off-by: Robin Murphy <[email protected]>
Reviewed-by: Eric Auger <[email protected]>
Regards
Eric
> ---
> drivers/iommu/dma-iommu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
> index 48d36ce59efb..1e0983488a8d 100644
> --- a/drivers/iommu/dma-iommu.c
> +++ b/drivers/iommu/dma-iommu.c
> @@ -175,8 +175,7 @@ static void iova_reserve_pci_windows(struct pci_dev *dev,
> unsigned long lo, hi;
>
> resource_list_for_each_entry(window, &bridge->windows) {
> - if (resource_type(window->res) != IORESOURCE_MEM &&
> - resource_type(window->res) != IORESOURCE_IO)
> + if (resource_type(window->res) != IORESOURCE_MEM)
> continue;
>
> lo = iova_pfn(iovad, window->res->start - window->offset);
>
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
