From: Joerg Roedel <jroe...@suse.de>

Add support for the iommu_device_register interface to make
the s390 hardware iommus visible to the iommu core and in
sysfs.

Signed-off-by: Joerg Roedel <jroe...@suse.de>
---
 arch/s390/include/asm/pci.h |  1 +
 drivers/iommu/s390-iommu.c  | 30 ++++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/arch/s390/include/asm/pci.h b/arch/s390/include/asm/pci.h
index 045665d..8c071af 100644
--- a/arch/s390/include/asm/pci.h
+++ b/arch/s390/include/asm/pci.h
@@ -124,6 +124,7 @@ struct zpci_dev {
        unsigned long   iommu_pages;
        unsigned int    next_bit;
 
+       struct iommu_device iommu_dev;  /* IOMMU core handle */
        struct iommu_group *group;      /* IOMMU group for all devices behind 
this zdev */
 
        char res_name[16];
diff --git a/drivers/iommu/s390-iommu.c b/drivers/iommu/s390-iommu.c
index cad3ad0..ec7f5e4 100644
--- a/drivers/iommu/s390-iommu.c
+++ b/drivers/iommu/s390-iommu.c
@@ -18,6 +18,8 @@
  */
 #define S390_IOMMU_PGSIZES     (~0xFFFUL)
 
+static struct iommu_ops s390_iommu_ops;
+
 struct s390_domain {
        struct iommu_domain     domain;
        struct list_head        devices;
@@ -173,10 +175,13 @@ static struct iommu_group *s390_iommu_device_group(struct 
device *dev)
 static int s390_iommu_add_device(struct device *dev)
 {
        struct iommu_group *group = iommu_group_get_for_dev(dev);
+       struct zpci_dev *zdev = to_pci_dev(dev)->sysdata;
+
        if (IS_ERR(group))
                return PTR_ERR(group);
 
        iommu_group_put(group);
+       iommu_device_link(&zdev->iommu_dev, dev);
 
        return 0;
 }
@@ -203,6 +208,7 @@ static void s390_iommu_remove_device(struct device *dev)
                        s390_iommu_detach_device(domain, dev);
        }
 
+       iommu_device_unlink(&zdev->iommu_dev, dev);
        iommu_group_remove_device(dev);
 }
 
@@ -342,13 +348,37 @@ int zpci_init_iommu(struct zpci_dev *zdev)
        if (IS_ERR(zdev->group)) {
                rc = PTR_ERR(zdev->group);
                zdev->group = NULL;
+               goto out_err;
        }
 
+       rc = iommu_device_sysfs_add(&zdev->iommu_dev, NULL, NULL,
+                                   "s390-iommu.%08x", zdev->fid);
+       if (rc)
+               goto out_group;
+
+       iommu_device_set_ops(&zdev->iommu_dev, &s390_iommu_ops);
+
+       rc = iommu_device_register(&zdev->iommu_dev);
+       if (rc)
+               goto out_sysfs;
+
+       return 0;
+
+out_sysfs:
+       iommu_device_sysfs_remove(&zdev->iommu_dev);
+
+out_group:
+       iommu_group_put(zdev->group);
+       zdev->group = NULL;
+
+out_err:
        return rc;
 }
 
 void zpci_destroy_iommu(struct zpci_dev *zdev)
 {
+       iommu_device_unregister(&zdev->iommu_dev);
+       iommu_device_sysfs_remove(&zdev->iommu_dev);
        iommu_group_put(zdev->group);
        zdev->group = NULL;
 }
-- 
1.9.1

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to