Hi,
On 17/05/2017 16:32, Robin Murphy wrote:
> On 17/05/17 13:36, Joerg Roedel wrote:
>> On Mon, May 15, 2017 at 04:01:30PM +0100, Robin Murphy wrote:
>>> When __iommu_dma_map() and iommu_dma_free_iova() are called from
>>> iommu_dma_get_msi_page(), various iova_*() helpers are still invoked in
>>> the process, whcih is unwise since they access a different member of the
>>> union (the iova_domain) from that which was last written, and there's no
>>> guarantee that sensible values will result anyway.
>>>
>>> CLean up the code paths that are valid for an MSI cookie to ensure we
>>> only do iova_domain-specific things when we're actually dealing with one.
>>>
>>> Fixes: a44e6657585b ("iommu/dma: Clean up MSI IOVA allocation")
>>> Reported-by: Nate Watterson <[email protected]>
>>> Tested-by: Shanker Donthineni <[email protected]>
>>> Tested-by: Bharat Bhushan <[email protected]>
>>> Signed-off-by: Robin Murphy <[email protected]>
>>
>> Applied to iommu/fixes.
>
> Thanks!
>
>> Why didn't you add the Tested-by from Eric in
>> you resend?
>
> Mostly due to the relative timing of those two events ;)
Yes no worries. I showed up later!
Thanks
Eric
>
> Robin.
>
>>
>>
>> Joerg
>>
>
> _______________________________________________
> iommu mailing list
> [email protected]
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
>
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
