On Tue, 2017-12-19 at 23:30 +0200, Andy Shevchenko wrote: > On Tue, 2017-12-19 at 13:08 -0800, Sohil Mehta wrote: > > > > Debugfs extension for Intel IOMMU to dump Interrupt remapping table > > entries for Interrupt remapping and Interrupt posting. > > > > The file /sys/kernel/debug/intel_iommu/ir_translation_struct > > provides > > detailed information, such as Index, Source Id, Destination Id, > > Vector > > and the raw values for entries with the present bit set, in the > > format > > shown. > > > > Remapped Interrupt supported on IOMMU: dmar5 > > IR table address:ffff93e09d54c310 > > ----------------------------------------------------------- > > Index SID Dest_ID Vct Raw_value_high Raw_value_low > > 1 3a00 00000600 2c 0000000000043a00 00000600002c0009 > > 111 4301 00000900 a2 0000000000044301 0000090000a20009 > > > > Posted Interrupt supported on IOMMU: dmar5 > > IR table address:ffff93e09d54c310 > > ----------------------------------------------------------------- > > --- > > Index SID PDA_high PDA_low Vct Raw_value_high Raw_value_low > > 4 4300 00000010 40c7c880 41 0000001000044300 > > 40c7c88000418001 > > 5 4300 00000010 40c7c880 51 0000001000044300 > > 40c7c88000518001 > > > > > > > > + seq_printf(m, "\nRemapped Interrupt supported on > > IOMMU: %s\n" > Please, avoid leading \n.
Sure. I'll add a separate seq_puts(m, "\n") after each of the loops to avoid having the leading '\n's. > > > > > + " IR table address:%p\n", iommu->name, > > + iommu->ir_table); > > + > > + seq_puts(m, "------------------------------------- > > - > > ---------" > > + "------------\n"); > It's okay to use long string literal on one line. So, don't split (or > for multi-line string literals, split by \n like you do above). > Thanks. Will fix this and the other one. > > > > + seq_puts(m, > > "\n****\t****\t****\t****\t****\t****\t****\t****\n"); > Leading \n. > > > > > + seq_printf(m, "\nPosted Interrupt supported on > > IOMMU: > > %s\n" > Ditto. > > > > > + " IR table address:%p\n", iommu->name, > > + iommu->ir_table); > > + > > + seq_puts(m, "------------------------------------- > > - > > ----------" > > + "--------------------\n"); > Join back. > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
