On 17/01/18 13:53, Joerg Roedel wrote:
Hi Robin,

On Wed, Jan 17, 2018 at 01:39:18PM +0000, Robin Murphy wrote:
Oops, patch #2 of this series will break the build, as it was accidentally
based on an older branch missing the Renesas IPMMU updates.

So patch #2 needs the ipmmu-patch from your v2 post to build? I am a bit
confused...

Please see v2 [1] - I'm still hoping for confirmation from the Renesas
folks, but it *should* be fine...

I can apply the patches again from your v2 post, thats fine, I just want
to understand the dependencies first.

The IOMMU_OF_DECLARE() in ipmmu-vmsa.c added in 4.15 is missed by the prototype change in (4.14-based) v1 2/2 - by applying v2 2/3 on top of the two v1 patches you will end up with an extra NULL argument there which will then fail to compile. v2 3/3 supersedes v1 2/2 by removing that one as well. This is entirely my fault for hacking out some quick patches on top of unrelated development work instead of creating a fresh branch...

Incidentally, per your other mail, these changes also makes Jeffy's "Only do
IOMMU lookup for available ones" patch obsolete.

Okay, thanks for letting me know.

Cheers,
Robin.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to