Hi Suravee,

I love your patch! Yet something to improve:

[auto build test ERROR on iommu/next]
[also build test ERROR on v4.15 next-20180202]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Suravee-Suthikulpanit/iommu-Fix-iommu_unmap-and-iommu_unmap_fast-return-type/20180203-015316
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: s390-allyesconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=s390 

All errors (new ones prefixed by >>):

>> drivers//iommu/s390-iommu.c:373:11: error: initialization from incompatible 
>> pointer type [-Werror=incompatible-pointer-types]
     .unmap = s390_iommu_unmap,
              ^~~~~~~~~~~~~~~~
   drivers//iommu/s390-iommu.c:373:11: note: (near initialization for 
's390_iommu_ops.unmap')
   cc1: some warnings being treated as errors

vim +373 drivers//iommu/s390-iommu.c

f42c22351 Joerg Roedel    2017-04-27  365  
cceb84519 Arvind Yadav    2017-08-28  366  static const struct iommu_ops 
s390_iommu_ops = {
8128f23c4 Gerald Schaefer 2015-08-27  367       .capable = s390_iommu_capable,
8128f23c4 Gerald Schaefer 2015-08-27  368       .domain_alloc = 
s390_domain_alloc,
8128f23c4 Gerald Schaefer 2015-08-27  369       .domain_free = s390_domain_free,
8128f23c4 Gerald Schaefer 2015-08-27  370       .attach_dev = 
s390_iommu_attach_device,
8128f23c4 Gerald Schaefer 2015-08-27  371       .detach_dev = 
s390_iommu_detach_device,
8128f23c4 Gerald Schaefer 2015-08-27  372       .map = s390_iommu_map,
8128f23c4 Gerald Schaefer 2015-08-27 @373       .unmap = s390_iommu_unmap,
8128f23c4 Gerald Schaefer 2015-08-27  374       .iova_to_phys = 
s390_iommu_iova_to_phys,
8128f23c4 Gerald Schaefer 2015-08-27  375       .add_device = 
s390_iommu_add_device,
8128f23c4 Gerald Schaefer 2015-08-27  376       .remove_device = 
s390_iommu_remove_device,
0929deca4 Joerg Roedel    2017-06-15  377       .device_group = 
generic_device_group,
8128f23c4 Gerald Schaefer 2015-08-27  378       .pgsize_bitmap = 
S390_IOMMU_PGSIZES,
8128f23c4 Gerald Schaefer 2015-08-27  379  };
8128f23c4 Gerald Schaefer 2015-08-27  380  

:::::: The code at line 373 was first introduced by commit
:::::: 8128f23c436d0dd4f72412e1bf9256e424479dc3 iommu/s390: Add iommu api for 
s390 pci devices

:::::: TO: Gerald Schaefer <gerald.schae...@de.ibm.com>
:::::: CC: Joerg Roedel <jroe...@suse.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to