Hi Jacob, I love your patch! Perhaps something to improve:
[auto build test WARNING on iommu/next] [also build test WARNING on v4.16-rc6 next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jacob-Pan/IOMMU-and-VT-d-driver-support-for-Shared-Virtual-Address-SVA/20180325-024555 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/iommu/intel-iommu.c:500:5: sparse: symbol 'intel_iommu_gfx_mapped' was not declared. Should it be static? drivers/iommu/intel-iommu.c:3066:41: sparse: incorrect type in argument 1 (different address spaces) @@ expected void volatile [noderef] <asn:2>*addr @@ got ile [noderef] <asn:2>*addr @@ drivers/iommu/intel-iommu.c:3066:41: expected void volatile [noderef] <asn:2>*addr drivers/iommu/intel-iommu.c:3066:41: got struct context_entry *old_ce >> drivers/iommu/intel-iommu.c:5198:5: sparse: symbol >> 'intel_iommu_page_response' was not declared. Should it be static? >> drivers/iommu/intel-iommu.c:5224:48: sparse: right shift by bigger than >> source value Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
