On Tue, 2018-07-03 at 07:40 +0100, Colin King wrote: > Currently tag is being assigned but not used, it is missing from > the dev_err message, so add it in. > > Cleans up clang warning: > warning: variable 'tag' set but not used [-Wunused-but-set-variable] [] > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c [] > @@ -616,9 +616,9 @@ static void iommu_print_event(struct amd_iommu *iommu, > void *__evt) > pasid = ((event[0] >> 16) & 0xFFFF) > | ((event[1] << 6) & 0xF0000); > tag = event[1] & 0x03FF; > - dev_err(dev, "INVALID_PPR_REQUEST device=%02x:%02x.%x > pasid=0x%05x address=0x%016llx flags=0x%04x]\n", > + dev_err(dev, "INVALID_PPR_REQUEST device=%02x:%02x.%x > pasid=0x%05x address=0x%016llx flags=0x%04x tag=0x%03x]\n", > PCI_BUS_NUM(devid), PCI_SLOT(devid), PCI_FUNC(devid), > - pasid, address, flags); > + pasid, address, flags, tag);
Seems to have a superfluous ] that should be removed. _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
