On 2018/7/13 9:48, Leizhen (ThunderTown) wrote: > > > On 2018/7/13 1:01, Will Deacon wrote: >> On Thu, Jul 12, 2018 at 05:28:43PM +0800, Zhen Lei wrote: >>> Stream bypass is not security. A malicious device can be hot plugged >>> without match any drivers, but it can access to any memory. So change to >>> disable bypass by default. >>> >>> Signed-off-by: Zhen Lei <[email protected]> >>> --- >>> drivers/iommu/arm-smmu-v3.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Whilst this sounds nice, I *bet* you it will break some systems. In >> particular, those where the SMMU is described but the toplogical information >> is either incorrect or incomplete. > > Suppose this scene exists, maybe we should consider updating IORT > specification, > to indicate whether a smmu treats all unregistered devices as stream bypass > or not, --- global control > to indicate whether a single device default use stream bypass or not, --- > local control > that will be more flexible. But we still disable bypass by default.
IORT (or dts) is about the hardware feature, if it's only about the wrong topological information of devices and SMMU, I think IORT is not the right place to describe such information, we need correct that information instead. Thanks Hanjun _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
