PCI_INTERRUPT_PIN should always read  0 for SRIOV Virtual Functions.

Some SRIOV devices have some bugs in RTL and VF's end up reading 1
instead of 0 for the PIN.

We could enforce it by default in vfio_pci_nointx.

Reported-by: Gage Eads <gage.e...@intel.com>
Tested-by: Gage Eads <gage.e...@intel.com>
Signed-off-by: Ashok Raj <ashok....@intel.com>
Cc: linux-ker...@vger.kernel.org
Cc: sta...@vger.kernel.org
Cc: iommu@lists.linux-foundation.org
Cc: Joerg Roedel <j...@8bytes.org>
Cc: Bjorn Helgaas <helg...@kernel.org>
Cc: Gage Eads <gage.e...@intel.com>
---
 drivers/vfio/pci/vfio_pci.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
index b423a30..bc3f4fa 100644
--- a/drivers/vfio/pci/vfio_pci.c
+++ b/drivers/vfio/pci/vfio_pci.c
@@ -192,6 +192,13 @@ static void vfio_pci_disable(struct vfio_pci_device *vdev);
  */
 static bool vfio_pci_nointx(struct pci_dev *pdev)
 {
+       /*
+        * Per PCI, no VF's should have INTx
+        * Simply disable it here
+        */
+       if (pdev->is_virtfn)
+               return true;
+
        switch (pdev->vendor) {
        case PCI_VENDOR_ID_INTEL:
                switch (pdev->device) {
-- 
2.7.4

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to