On Fri, Jul 20, 2018 at 10:45:45AM +0200, Anna-Maria Gleixner wrote: > The WARN_ON() was introduced in commit 272e4f99e966 ("iommu/amd: WARN > when __[attach|detach]_device are called with irqs enabled") to ensure > that the domain->lock is taken in proper irqs disabled context. This > is required, because the domain->lock is taken as well in irq > context. > > The proper context check by the WARN_ON() is redundant, because it is > already covered by LOCKDEP. When working with locks and changing > context, a run with LOCKDEP is required anyway and would detect the > wrong lock context. > > Furthermore all callers for those functions are within the same file > and all callers acquire another lock which already disables interrupts. > > Signed-off-by: Anna-Maria Gleixner <anna-ma...@linutronix.de> > --- > drivers/iommu/amd_iommu.c | 12 ------------ > 1 file changed, 12 deletions(-)
Applied, thanks. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu