Hi Lu Baolu, On Mon, Dec 10, 2018 at 10:57:22AM +0800, Lu Baolu wrote: > > /* Check if a device supports a given feature of the IOMMU-API */ > > bool iommu_dev_has_feature(struct device *dev, enum iommu_dev_features > > *feat); > > Here we pass in a pointer of "enum iommu_dev_features", do we want > to return anything here?
Yeah, this is a mistake on my side, The enum parameter should be passed by-value, so not pointer there. It doesn't need to return anything in this parameter. Regards, Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu