Re: [PATCH 1/9] iommu/vt-d: Allow interrupts from the entire bus for aliased devices

[Logan Gunthorpe]

On 2019-02-01 9:44 a.m., Joerg Roedel wrote:
> On Thu, Jan 31, 2019 at 11:56:48AM -0700, Logan Gunthorpe wrote:
>> @@ -394,6 +402,10 @@ static int set_msi_sid(struct irte *irte, struct 
>> pci_dev *dev)
>>              set_irte_sid(irte, SVT_VERIFY_BUS, SQ_ALL_16,
>>                           PCI_DEVID(PCI_BUS_NUM(data.alias),
>>                                     dev->bus->number));
>> +    else if (data.count >= 2 && data.busmatch_count == data.count)
>> +            set_irte_sid(irte, SVT_VERIFY_BUS, SQ_ALL_16,
>> +                         PCI_DEVID(dev->bus->number,
>> +                                   dev->bus->number));
> 
> The dev->bus->number argument for the devfn parameter of PCI_DEVID is
> not needed, right?

Oh, yes. I think you are right.

> Also, this requires at least a comment to document that special case.

I'll add a comment for v2.

Thanks for the review!

Logan
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu