> index 74e944bd4a8d..81d449451494 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1484,8 +1484,7 @@ static int arm_smmu_add_device(struct device *dev) > } > > ret = -ENOMEM; > - cfg = kzalloc(offsetof(struct arm_smmu_master_cfg, smendx[i]), > - GFP_KERNEL); > + cfg = kzalloc(struct_size(cfg, smendx, i), GFP_KERNEL);
This looks like a huge improvement, but I find the usage of i here still very obsfucating. Can we please use fwspec->num_ids directly instead of make it much more obvious? _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
