On Wed, 10 Apr 2019 22:02:01 -0500
Josh Poimboeuf <[email protected]> wrote:

> >  #ifdef CONFIG_STACKTRACE
> > -   struct           stack_trace stacktrace;
> > -   unsigned long    st_entries[DMA_DEBUG_STACKTRACE_ENTRIES];
> > +   unsigned int    st_len;
> > +   unsigned long   st_entries[DMA_DEBUG_STACKTRACE_ENTRIES];  
> 
> nit: st_entries isn't very readable.  Thanks to the magic of compilers,
> the characters are free, so why not call them "stacktrace_entries" and
> "stacktrace_len".

But doesn't that slow down the time it takes to compile?

/me runs...

-- Steve
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to