On Thu, Jul 25, 2019 at 04:39:59PM -0700, Nicolin Chen wrote:
> According to the original dma_direct_alloc_pages() code:
> {
> unsigned int count = PAGE_ALIGN(size) >> PAGE_SHIFT;
>
> if (!dma_release_from_contiguous(dev, page, count))
> __free_pages(page, get_order(size));
> }
>
> The count parameter for dma_release_from_contiguous() was page
> aligned before the right-shifting operation, while the new API
> dma_free_contiguous() forgets to have PAGE_ALIGN() at the size.
>
> So this patch simply adds it to prevent any corner case.
>
> Fixes: fdaeec198ada ("dma-contiguous: add dma_{alloc,free}_contiguous()
> helpers")
> Signed-off-by: Nicolin Chen <[email protected]>
Looks good,
Reviewed-by: Christoph Hellwig <[email protected]>
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
