On 8/6/19 10:46 AM, Christoph Hellwig wrote: > On Tue, Aug 06, 2019 at 02:18:49PM +0000, Lendacky, Thomas wrote: >> I think you need to keep everything inside the original if statement since >> the caller is expecting a page pointer to be returned in this case and not >> the page_address() which is returned when the DMA_ATTR_NO_KERNEL_MAPPING >> is not present. > > DMA_ATTR_NO_KERNEL_MAPPING is defined to return an opaque cookie, > which just happens to be a page pointer. So if we fix up the free side > as pointed out by Lucas we should be fine.
As long as two different cookie types (page pointer for encrypted DMA and virtual address returned from page_address() for unencrypted DMA) is ok. I'm just not familiar with how the cookie is used in any other functions, if at all. Thanks, Tom > _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
