Hi Bjorn, hi Stephen,
Am 20.08.19 um 07:43 schrieb Stefan Wahren: > Hi Christoph, > > Am 20.08.19 um 03:24 schrieb Christoph Hellwig: >> Hi Stefan, >> >> please try the patch below. >> >> --- >> From e0570628d96faa50ebfc94ce8e545968336db225 Mon Sep 17 00:00:00 2001 >> From: Christoph Hellwig <[email protected]> >> Date: Tue, 20 Aug 2019 10:08:38 +0900 >> Subject: arm: select the dma-noncoherent symbols for all swiotlb builds >> >> We need to provide the arch hooks for non-coherent dma-direct >> and swiotlb for all swiotlb builds, not just when LPAS is enabled. > s/LPAS/LPAE/ >> Without that the Xen build that selects SWIOTLB indirectly through >> SWIOTLB_XEN fails to build. >> >> Fixes: ad3c7b18c5b3 ("arm: use swiotlb for bounce buffering on LPAE configs") >> Reported-by: Stefan Wahren <[email protected]> >> Signed-off-by: Christoph Hellwig <[email protected]> > i applied this patch and it fixes the build issue i reported before. But > this seems to reveal another build issue in drivers/firmware/qcom_scm.c: > > drivers/firmware/qcom_scm.c: In function ‘qcom_scm_assign_mem’: > drivers/firmware/qcom_scm.c:460:47: error: passing argument 3 of > ‘dma_alloc_coherent’ from incompatible pointer type > [-Werror=incompatible-pointer-types] > ptr = dma_alloc_coherent(__scm->dev, ptr_sz, &ptr_phys, GFP_KERNEL); > ^ > In file included from drivers/firmware/qcom_scm.c:12:0: > ./include/linux/dma-mapping.h:636:21: note: expected ‘dma_addr_t * {aka > long long unsigned int *}’ but argument is of type ‘phys_addr_t * {aka > unsigned int *}’ > static inline void *dma_alloc_coherent(struct device *dev, size_t size, > ^~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > scripts/Makefile.build:280: die Regel für Ziel > „drivers/firmware/qcom_scm.o“ scheiterte > > Luckily there is already a patch to fix this in linux-next: > > firmware: qcom_scm: Use proper types for dma mappings could you please take care that this patch is applied to 5.3-fixes? > > It seems that it misses the fixes tag. > > Regards > Stefan > > > _______________________________________________ > linux-arm-kernel mailing list > [email protected] > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
