> From: [email protected]
> <[email protected]> On Behalf Of Wei Hu
> Sent: Tuesday, October 22, 2019 4:11 AM
> ...
> + /* Allocate from CMA */
> + // request_pages = (request_size >> PAGE_SHIFT) + 1;
"//" seems rare in Linux kernel code.
IMO "/* */" is more common.
> + pr_info("Unable to allocate enough contiguous physical
> memory
> on Gen 1 VM. Use MMIO instead.\n");
The line exceeds 80 chars.
> @@ -1060,6 +1168,7 @@ static int hvfb_probe(struct hv_device *hdev,
> par = info->par;
> par->info = info;
> par->fb_ready = false;
> + par->need_docopy = false;
Maybe it's better if we set the default value to true? This way we can save
the " par->need_docopy = true;" in hvfb_getmem().
Thanks,
-- Dexuan
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
