On Mon, Dec 09, 2019 at 12:55:22PM +0000, Robin Murphy wrote:
> On 09/12/2019 12:38 pm, Jean-Philippe Brucker wrote:
> > Since commit 781ca2de89ba ("iommu: Add gfp parameter to
> > iommu_ops::map"), iommu_map() might sleep. iommu_dma_get_msi_page() runs
> > in atomic context and thus should call iommu_map_atomic() instead.
>
> Spooky... I'm rebasing my local branches and this arrived at the exact
> moment I came across my fix[1] that I'd otherwise forgotten about. As
> covered there, this really doesn't need to be atomic at all now, so I'd
> prefer to see it cleaned up more thoroughly.
>
> Robin.
>
> [1]
> https://lore.kernel.org/linux-iommu/5af5e77102ca52576cb96816f0abcf6398820055.1571245656.git.robin.mur...@arm.com/
Oh right I did see it back then, but forgot about it. Much better than my
patch and it fixes my boot splats (and doesn't raise any new lockdep
warning either).
Thanks,
Jean
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
