On Tue, Feb 18, 2020 at 05:40:39PM +0000, Robin Murphy wrote: > On 18/02/2020 5:27 pm, Will Deacon wrote: > > Extending the Arm SMMU driver to allow for modular builds changed > > KBUILD_MODNAME to be "arm_smmu_mod" so that a single module could be > > built from the multiple existing object files without the need to rename > > any source files. > > > > This inadvertently changed the name of the driver parameters, which may > > lead to runtime issues if bootloaders are relying on the old names for > > correctness (e.g. "arm-smmu.disable_bypass=0"). > > Indeed, it turns out this also tripped up some Juno setups in our internal > CI that were bodging around firmware issues. > > > Although MODULE_PARAM_PREFIX can be overridden to restore the old naming > > for builtin parameters, only the new name is matched by modprobe and so > > loading the driver as a module would cause parameters specified on the > > kernel command line to be ignored. Instead, rename "arm_smmu_mod" to > > "arm_smmu". Whilst it's a bit of a bodge, this allows us to create a > > single module without renaming any files and makes use of the fact that > > underscores and hyphens can be used interchangeably in parameter names. > > That's awful... and thus great :) > > Reviewed-by: Robin Murphy <[email protected]>
Cheers, Robin! Joerg -- please can you pick this up as a fix for 5.6? I don't have any other SMMU fixes queued, so it doesn't seem worth sending a pull request to you just for this. Thanks, Will _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
