> > On 2020/2/17 5:57, Sai Praneeth Prakhya wrote: > > The functionality needed for iommu_ops->dev_def_domain_type() is > > already provided by device_def_domain_type() in intel_iommu.c. But, > > every call back function in intel_iommu_ops starts with intel_iommu > > prefix, hence rename > > device_def_domain_type() to intel_iommu_dev_def_domain_type() so that > > it follows the same semantics. > > How about keep device_def_domain_type() and call it in the new > intel_iommu_dev_def_domain_type()?
Sure! I could but could you please explain the advantages we might get by doing so? Less number of changes is what I could think of.. any other reasons? Regards, Sai _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu