On Sun, 2020-09-06 at 17:19 +0200, Fabien Parent wrote:

> Add a new flag in order to select which IVRP_PADDR format is used
> by an SoC.
> 
> Signed-off-by: Fabien Parent <[email protected]>


Reviewed-by: Yong Wu <[email protected]>


> ---
> 
> v3: set LEGACY_IVRP_PADDR as a flag instead of platform data
> v2: new patch
> 
> ---
>  drivers/iommu/mtk_iommu.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index 785b228d39a6..b1f85a7e9346 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -116,6 +116,7 @@
>  #define OUT_ORDER_WR_EN                      BIT(4)
>  #define HAS_SUB_COMM                 BIT(5)
>  #define WR_THROT_EN                  BIT(6)
> +#define HAS_LEGACY_IVRP_PADDR                BIT(7)
>  
>  #define MTK_IOMMU_HAS_FLAG(pdata, _x) \
>               ((((pdata)->flags) & (_x)) == (_x))
> @@ -582,7 +583,7 @@ static int mtk_iommu_hw_init(const struct mtk_iommu_data 
> *data)
>               F_INT_PRETETCH_TRANSATION_FIFO_FAULT;
>       writel_relaxed(regval, data->base + REG_MMU_INT_MAIN_CONTROL);
>  
> -     if (data->plat_data->m4u_plat == M4U_MT8173)
> +     if (MTK_IOMMU_HAS_FLAG(data->plat_data, HAS_LEGACY_IVRP_PADDR))
>               regval = (data->protect_base >> 1) | (data->enable_4GB << 31);
>       else
>               regval = lower_32_bits(data->protect_base) |
> @@ -818,7 +819,8 @@ static const struct mtk_iommu_plat_data mt6779_data = {
>  
>  static const struct mtk_iommu_plat_data mt8173_data = {
>       .m4u_plat     = M4U_MT8173,
> -     .flags        = HAS_4GB_MODE | HAS_BCLK | RESET_AXI,
> +     .flags        = HAS_4GB_MODE | HAS_BCLK | RESET_AXI |
> +                     HAS_LEGACY_IVRP_PADDR,
>       .inv_sel_reg  = REG_MMU_INV_SEL_GEN1,
>       .larbid_remap = {{0}, {1}, {2}, {3}, {4}, {5}}, /* Linear mapping. */
>  };


_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to