Gentle ping. -- Adrian
> -----Original Message----- > From: Adrian Huang <[email protected]> > Sent: Monday, October 12, 2020 3:01 PM > To: Joerg Roedel <[email protected]> > Cc: [email protected]; Adrian Huang > <[email protected]>; Adrian Huang12 <[email protected]> > Subject: [External] [PATCH 1/1] iommu/amd: Remove unnecessary assignment > > From: Adrian Huang <[email protected]> > > The values of local variables are assigned after local variables are > declared, so no > need to assign the initial value during the variable declaration. > > And, no need to assign NULL for the local variable 'ivrs_base' > after invoking acpi_put_table(). > > Signed-off-by: Adrian Huang <[email protected]> > --- > drivers/iommu/amd/init.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c index > 1ba6b4cc56e8..f171078f7ea0 100644 > --- a/drivers/iommu/amd/init.c > +++ b/drivers/iommu/amd/init.c > @@ -1858,7 +1858,7 @@ static void print_iommu_info(void) static int __init > amd_iommu_init_pci(void) { > struct amd_iommu *iommu; > - int ret = 0; > + int ret; > > for_each_iommu(iommu) { > ret = iommu_init_pci(iommu); > @@ -2494,8 +2494,8 @@ static void __init free_dma_resources(void) static int > __init early_amd_iommu_init(void) { > struct acpi_table_header *ivrs_base; > + int i, remap_cache_sz, ret; > acpi_status status; > - int i, remap_cache_sz, ret = 0; > u32 pci_id; > > if (!amd_iommu_detected) > @@ -2637,7 +2637,6 @@ static int __init early_amd_iommu_init(void) > out: > /* Don't leak any ACPI memory */ > acpi_put_table(ivrs_base); > - ivrs_base = NULL; > > return ret; > } > -- > 2.17.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
