From: Sugar <[email protected]>

we should check the ret-val of function rk_iommu_from_dev to avoid 
null-ptr-deref.

Signed-off-by: Sugar <[email protected]>
---
 drivers/iommu/rockchip-iommu.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
index e5d86b7177de..311d9eec06f4 100644
--- a/drivers/iommu/rockchip-iommu.c
+++ b/drivers/iommu/rockchip-iommu.c
@@ -1064,6 +1064,9 @@ static struct iommu_device *rk_iommu_probe_device(struct 
device *dev)
                return ERR_PTR(-ENODEV);
 
        iommu = rk_iommu_from_dev(dev);
+       if (!iommu) {
+               return ERR_PTR(-ENODEV);
+       }
 
        data->link = device_link_add(dev, iommu->dev,
                                     DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME);
@@ -1083,6 +1086,9 @@ static struct iommu_group *rk_iommu_device_group(struct 
device *dev)
        struct rk_iommu *iommu;
 
        iommu = rk_iommu_from_dev(dev);
+       if (!iommu) {
+               return ERR_PTR(-ENODEV);
+       }
 
        return iommu_group_ref_get(iommu->group);
 }
-- 
2.29.2

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to