Hi Jean-Philippe, I love your patch! Yet something to improve:
[auto build test ERROR on pm/linux-next] [also build test ERROR on iommu/next arm64/for-next/core linus/master v5.13-rc4 next-20210602] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jean-Philippe-Brucker/Add-support-for-ACPI-VIOT/20210602-235849 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: x86_64-randconfig-a012-20210602 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project d41cb6bb2607fa5c7a9df2b3dab361353657d225) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://github.com/0day-ci/linux/commit/937da71a81108243877fb1f0f568e56a08a62c50 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jean-Philippe-Brucker/Add-support-for-ACPI-VIOT/20210602-235849 git checkout 937da71a81108243877fb1f0f568e56a08a62c50 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <[email protected]> All errors (new ones prefixed by >>): >> drivers/acpi/scan.c:1540:26: error: no member named 'ops' in 'struct >> iommu_fwspec' return fwspec ? fwspec->ops : NULL; ~~~~~~ ^ >> drivers/acpi/scan.c:1564:9: error: implicit declaration of function >> 'iommu_probe_device' [-Werror,-Wimplicit-function-declaration] err = iommu_probe_device(dev); ^ 2 errors generated. vim +1540 drivers/acpi/scan.c 1535 1536 static inline const struct iommu_ops *acpi_iommu_fwspec_ops(struct device *dev) 1537 { 1538 struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); 1539 > 1540 return fwspec ? fwspec->ops : NULL; 1541 } 1542 1543 static const struct iommu_ops *acpi_iommu_configure_id(struct device *dev, 1544 const u32 *id_in) 1545 { 1546 int err; 1547 const struct iommu_ops *ops; 1548 1549 /* 1550 * If we already translated the fwspec there is nothing left to do, 1551 * return the iommu_ops. 1552 */ 1553 ops = acpi_iommu_fwspec_ops(dev); 1554 if (ops) 1555 return ops; 1556 1557 err = iort_iommu_configure_id(dev, id_in); 1558 1559 /* 1560 * If we have reason to believe the IOMMU driver missed the initial 1561 * add_device callback for dev, replay it to get things in order. 1562 */ 1563 if (!err && dev->bus && !device_iommu_mapped(dev)) > 1564 err = iommu_probe_device(dev); 1565 1566 /* Ignore all other errors apart from EPROBE_DEFER */ 1567 if (err == -EPROBE_DEFER) { 1568 return ERR_PTR(err); 1569 } else if (err) { 1570 dev_dbg(dev, "Adding to IOMMU failed: %d\n", err); 1571 return NULL; 1572 } 1573 return acpi_iommu_fwspec_ops(dev); 1574 } 1575 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/[email protected]
.config.gz
Description: application/gzip
_______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
