On Thu, May 13, 2021 at 03:58:15PM +0800, Zhen Lei wrote:
> Function iommu_group_store_type() is the only caller of the static
> function iommu_change_dev_def_domain() and has performed
> "if (WARN_ON(!group))" detection before calling it. So the one here is
> redundant.
>
> Signed-off-by: Zhen Lei <[email protected]>
> ---
> drivers/iommu/iommu.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied, thanks.
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 971068da67cb91d..8cdf6a1c4bfd773 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -3059,9 +3059,6 @@ static int iommu_change_dev_def_domain(struct
> iommu_group *group,
> int ret, dev_def_dom;
> struct device *dev;
>
> - if (!group)
> - return -EINVAL;
> -
> mutex_lock(&group->mutex);
>
> if (group->default_domain != group->domain) {
> --
> 2.26.0.106.g9fadedd
>
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
