On 14/06/2021 18:19, Robin Murphy wrote:
We shouldn't need to keep IOMMU_CMD_LINE_STRICT at all now, since it
was only to prevent a driver's "default lazy" setting passed in here
from downgrading an explicitly-set strict mode.
With that cleaned up too,
Patch 1/5 mentions whether the invalidation policy comes from the
cmdline - similar to the default domain type print - so I was going to
keep that.
Oh, silly me, I'd forgotten that already and was just looking at my
local tree... Let's keep it for consistency with how we report the
domain type then.
And then maybe we should also set it from the deprecated x86
driver-specific params.
I don't think it's worth exporting more low-level guts to allow that to
happen - tying in to iommu_set_dma_strict() would be too late, as
before. I think the separate pr_warn()s which announce the relevant
parameter is deprecated (but has still taken effect) should be enough.
Fine, I suppose someone using a deprecated interface can't complain
about imperfect prints.
And I'll pick up your RB tag (unless you mention otherwise).
Thanks,
John
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu