> On Jun 15, 2021, at 3:42 AM, Robin Murphy <[email protected]> wrote:
>
> On 2021-06-07 19:25, Nadav Amit wrote:
>> From: Robin Murphy <[email protected]>
>> The Mediatek driver is not the only one which might want a basic
>> address-based gathering behaviour, so although it's arguably simple
>> enough to open-code, let's factor it out for the sake of cleanliness.
>> Let's also take this opportunity to document the intent of these
>> helpers for clarity.
>> Cc: Joerg Roedel <[email protected]>
>> Cc: Will Deacon <[email protected]>
>> Cc: Jiajun Cao <[email protected]>
>> Cc: Robin Murphy <[email protected]>
>> Cc: Lu Baolu <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>> Signed-off-by: Robin Murphy <[email protected]>
>
> Nit: missing your signoff.
>
>> ---
>> Changes from Robin's version:
>> * Added iommu_iotlb_gather_add_range() stub !CONFIG_IOMMU_API
>
> Out of curiosity, is there any config in which a stub is actually needed?
> Unlike iommu_iotlb_gather_init(), I would have thought that these helpers
> should only ever be called by driver code which already depends on IOMMU_API.
Indeed, this was only done as a defensive step.
I will remove it. I see no reason for it. Sorry for ruining your patch.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
