Hi Ikjoon, Thanks very much for your help reviewing..
On Wed, 2021-07-21 at 19:43 +0800, Ikjoon Jang wrote: > On Thu, Jul 15, 2021 at 8:25 PM Yong Wu <yong...@mediatek.com> wrote: > > > > In mt8195, there are some larbs connect with the smi-sub-common, then > > connect with smi-common. > > Not critical but I suggest to describe what is smi-sub-common. > e.g. "some larbs are not directly connected to smi-common, > they are connected to smi-sub-common which is a bridge(?) interface to..." OK. I will add some brief description about this sub-common in next version. > > > > > Before we create device link between smi-larb with smi-common. If we have > > sub-common, we should use device link the smi-larb and smi-sub-common, > > then use device link between the smi-sub-common with smi-common. This is > > for enabling clock/power automatically. > > > > Move the device link code to a new interface for reusing. > > > > There is no SW extra setting for smi-sub-common. > > > > Signed-off-by: Yong Wu <yong...@mediatek.com> > > Reviewed-by: Ikjoon Jang <i...@chromium.org> Thanks. > > > --- > > drivers/memory/mtk-smi.c | 75 +++++++++++++++++++++++++++------------- > > 1 file changed, 51 insertions(+), 24 deletions(-) > > > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > > index e68cbb51dd12..ee49bb50f5f5 100644 > > --- a/drivers/memory/mtk-smi.c > > +++ b/drivers/memory/mtk-smi.c > > @@ -60,7 +60,8 @@ [snip..] _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
