Reviewed-by: Alyssa Rosenzweig <aly...@rosenzweig.io>
On Wed, Oct 13, 2021 at 02:34:41AM -0400, Wan Jiabing wrote:
> Fix following coccicheck warning:
> drivers/iommu/apple-dart.c:704:20-27: WARNING opportunity for kmemdup
>
> Signed-off-by: Wan Jiabing <wanjiab...@vivo.com>
> ---
> drivers/iommu/apple-dart.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
> index 280ff8df728d..5eeb8d6b72e2 100644
> --- a/drivers/iommu/apple-dart.c
> +++ b/drivers/iommu/apple-dart.c
> @@ -701,13 +701,12 @@ static struct iommu_group
> *apple_dart_device_group(struct device *dev)
> if (!group)
> goto out;
>
> - group_master_cfg = kzalloc(sizeof(*group_master_cfg), GFP_KERNEL);
> + group_master_cfg = kmemdup(cfg, sizeof(*group_master_cfg), GFP_KERNEL);
> if (!group_master_cfg) {
> iommu_group_put(group);
> goto out;
> }
>
> - memcpy(group_master_cfg, cfg, sizeof(*group_master_cfg));
> iommu_group_set_iommudata(group, group_master_cfg,
> apple_dart_release_group);
>
> --
> 2.20.1
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
