On Mon, Dec 06, 2021 at 04:33:10PM +0000, Robin Murphy wrote:
> On 2021-11-11 06:50, Christoph Hellwig wrote:
>> Add two local variables to track if we want to remap the returned
>> address using vmap or call dma_set_uncached and use that to simplify
>> the code flow.
>
> I still wonder about the asymmetry between the remap and set_uncached cases 
> WRT the memset(), which stands out even more the further we clean things 
> up, but that's another matter.

The memset for the remap case obviously needs to be done after
remapping. OTOH for the set_uncached case the memset is much faste
when done on the cached mapping, which must be done before calling
arch_dma_set_uncached.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to