On 13/01/2022 12:10, Yong Wu wrote: > Function clk_bulk_prepare_enable() returns 0 for success or a negative > number for error. Fix this code style issue.
The message does not really make sense. If negative is returned, then the check (ret < 0) was correct. I guess you wanted to say that common code style is to check for any non-zero return value, just like it's implementation in clk.h does. I'll adjust the commit msg when applying. > > Signed-off-by: Yong Wu <[email protected]> > Reviewed-by: AngeloGioacchino Del Regno > <[email protected]> > --- > drivers/memory/mtk-smi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index b883dcc0bbfa..e7b1a22b12ea 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -480,7 +480,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct > device *dev) > int ret; > > ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb->smi.clks); > - if (ret < 0) > + if (ret) > return ret; > > /* Configure the basic setting for this larb */ > Best regards, Krzysztof _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
