Stop calling bus_set_iommu() since it's now unnecessary, and simplify
the probe failure path accordingly.

Signed-off-by: Robin Murphy <[email protected]>
---
 drivers/iommu/virtio-iommu.c | 24 ------------------------
 1 file changed, 24 deletions(-)

diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c
index 25be4b822aa0..371f8657c0ce 100644
--- a/drivers/iommu/virtio-iommu.c
+++ b/drivers/iommu/virtio-iommu.c
@@ -7,7 +7,6 @@
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
-#include <linux/amba/bus.h>
 #include <linux/delay.h>
 #include <linux/dma-iommu.h>
 #include <linux/dma-map-ops.h>
@@ -1146,26 +1145,6 @@ static int viommu_probe(struct virtio_device *vdev)
 
        iommu_device_register(&viommu->iommu, &viommu_ops, parent_dev);
 
-#ifdef CONFIG_PCI
-       if (pci_bus_type.iommu_ops != &viommu_ops) {
-               ret = bus_set_iommu(&pci_bus_type, &viommu_ops);
-               if (ret)
-                       goto err_unregister;
-       }
-#endif
-#ifdef CONFIG_ARM_AMBA
-       if (amba_bustype.iommu_ops != &viommu_ops) {
-               ret = bus_set_iommu(&amba_bustype, &viommu_ops);
-               if (ret)
-                       goto err_unregister;
-       }
-#endif
-       if (platform_bus_type.iommu_ops != &viommu_ops) {
-               ret = bus_set_iommu(&platform_bus_type, &viommu_ops);
-               if (ret)
-                       goto err_unregister;
-       }
-
        vdev->priv = viommu;
 
        dev_info(dev, "input address: %u bits\n",
@@ -1174,9 +1153,6 @@ static int viommu_probe(struct virtio_device *vdev)
 
        return 0;
 
-err_unregister:
-       iommu_device_sysfs_remove(&viommu->iommu);
-       iommu_device_unregister(&viommu->iommu);
 err_free_vqs:
        vdev->config->del_vqs(vdev);
 
-- 
2.28.0.dirty

_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Reply via email to