[PATCH v2 06/14] iommu/arm-smmu-v3: Clean up bus_set_iommu()

[Robin Murphy]

Stop calling bus_set_iommu() since it's now unnecessary, and simplify
the probe failure path accordingly.

Acked-by: Will Deacon <w...@kernel.org>
Signed-off-by: Robin Murphy <robin.mur...@arm.com>
---
 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 53 +--------------------
 1 file changed, 2 insertions(+), 51 deletions(-)

diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c 
b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
index 627a3ed5ee8f..73b7b1b17b77 100644
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
@@ -28,8 +28,6 @@
 #include <linux/pci-ats.h>
 #include <linux/platform_device.h>
 
-#include <linux/amba/bus.h>
-
 #include "arm-smmu-v3.h"
 #include "../../iommu-sva-lib.h"
 
@@ -3698,43 +3696,6 @@ static unsigned long arm_smmu_resource_size(struct 
arm_smmu_device *smmu)
                return SZ_128K;
 }
 
-static int arm_smmu_set_bus_ops(struct iommu_ops *ops)
-{
-       int err;
-
-#ifdef CONFIG_PCI
-       if (pci_bus_type.iommu_ops != ops) {
-               err = bus_set_iommu(&pci_bus_type, ops);
-               if (err)
-                       return err;
-       }
-#endif
-#ifdef CONFIG_ARM_AMBA
-       if (amba_bustype.iommu_ops != ops) {
-               err = bus_set_iommu(&amba_bustype, ops);
-               if (err)
-                       goto err_reset_pci_ops;
-       }
-#endif
-       if (platform_bus_type.iommu_ops != ops) {
-               err = bus_set_iommu(&platform_bus_type, ops);
-               if (err)
-                       goto err_reset_amba_ops;
-       }
-
-       return 0;
-
-err_reset_amba_ops:
-#ifdef CONFIG_ARM_AMBA
-       bus_set_iommu(&amba_bustype, NULL);
-#endif
-err_reset_pci_ops: __maybe_unused;
-#ifdef CONFIG_PCI
-       bus_set_iommu(&pci_bus_type, NULL);
-#endif
-       return err;
-}
-
 static void __iomem *arm_smmu_ioremap(struct device *dev, resource_size_t 
start,
                                      resource_size_t size)
 {
@@ -3838,27 +3799,17 @@ static int arm_smmu_device_probe(struct platform_device 
*pdev)
        ret = iommu_device_register(&smmu->iommu, &arm_smmu_ops, dev);
        if (ret) {
                dev_err(dev, "Failed to register iommu\n");
-               goto err_sysfs_remove;
+               iommu_device_sysfs_remove(&smmu->iommu);
+               return ret;
        }
 
-       ret = arm_smmu_set_bus_ops(&arm_smmu_ops);
-       if (ret)
-               goto err_unregister_device;
-
        return 0;
-
-err_unregister_device:
-       iommu_device_unregister(&smmu->iommu);
-err_sysfs_remove:
-       iommu_device_sysfs_remove(&smmu->iommu);
-       return ret;
 }
 
 static int arm_smmu_device_remove(struct platform_device *pdev)
 {
        struct arm_smmu_device *smmu = platform_get_drvdata(pdev);
 
-       arm_smmu_set_bus_ops(NULL);
        iommu_device_unregister(&smmu->iommu);
        iommu_device_sysfs_remove(&smmu->iommu);
        arm_smmu_device_disable(smmu);
-- 
2.35.3.dirty

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu