SNP-enabled system requires IOMMU v1 page table to be configured with
non-zero DTE[Mode] for DMA-capable devices. This effects a number of
usecases such as IOMMU pass-through mode and AMD IOMMUv2 APIs for
binding/unbinding pasid.
The series introduce a global variable to check SNP-enabled state
during driver initialization, and use it to enforce the SNP restrictions
during runtime.
Also, for non-DMA-capable devices such as IOAPIC, the recommendation
is to set DTE[TV] and DTE[Mode] to zero on SNP-enabled system.
Therefore, additinal checks is added before setting DTE[TV].
Testing:
- Tested booting and verify dmesg.
- Tested booting with iommu=pt
- Tested loading amd_iommu_v2 driver
- Tested changing the iommu domain at runtime
- Tested booting SEV/SNP-enabled guest
- Tested when CONFIG_AMD_MEM_ENCRYPT is not set
Pre-requisite:
- [PATCH v3 00/35] iommu/amd: Add multiple PCI segments support
https://lore.kernel.org/linux-iommu/20220511072141.15485-29-vasant.he...@amd.com/T/
Chanages from V1:
(https://lore.kernel.org/linux-iommu/20220613012502.109918-1-suravee.suthikulpa...@amd.com/T/#t
)
- Remove the newly introduced domain_type_supported() callback.
- Patch 1: Modify existing check_feature_on_all_iommus() instead of
introducing another helper function to do similar check.
- Patch 3: Modify to use check_feature_on_all_iommus().
- Patch 4: Add IOMMU init_state check before enabling SNP.
Also move the function declaration to include/linux/amd-iommu.h
- Patch 6: Modify amd_iommu_domain_alloc() to fail when allocating identity
domain and SNP is enabled.
Best Regards,
Suravee
Brijesh Singh (1):
iommu/amd: Introduce function to check and enable SNP
Suravee Suthikulpanit (6):
iommu/amd: Warn when found inconsistency EFR mask
iommu/amd: Process all IVHDs before enabling IOMMU features
iommu/amd: Introduce an iommu variable for tracking SNP support status
iommu/amd: Set translation valid bit only when IO page tables are in
use
iommu/amd: Do not support IOMMU_DOMAIN_IDENTITY after SNP is enabled
iommu/amd: Do not support IOMMUv2 APIs when SNP is enabled
drivers/iommu/amd/amd_iommu_types.h | 5 ++
drivers/iommu/amd/init.c | 110 +++++++++++++++++++++++-----
drivers/iommu/amd/iommu.c | 28 ++++++-
include/linux/amd-iommu.h | 6 ++
4 files changed, 127 insertions(+), 22 deletions(-)
--
2.32.0
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
