On 2022/7/1 15:58, Tian, Kevin wrote:
From: Lu Baolu <baolu...@linux.intel.com> Sent: Wednesday, June 29,
2022 3:47 PM

The disable_dmar_iommu() is called when IOMMU initialization fails
or the IOMMU is hot-removed from the system. In both cases, there
is no need to clear the IOMMU translation data structures for

On the initialization path, the device probing only happens after
the IOMMU is initialized successfully, hence there're no
translation data structures.

On the hot-remove path, there is no real use case where the IOMMU
is hot-removed, but the devices that it manages are still alive in
the system. The translation data structures were torn down during
device release, hence there's no need to repeat it in IOMMU
hot-remove path either. This removes the unnecessary code and only
leaves a check.

Signed-off-by: Lu Baolu <baolu...@linux.intel.com>

You probably overlooked my last comment on kexec:


 I think my question is still not answered.

Sorry! I did overlook that comment. I can see your points now, though it
seems to be irrelevant to the problems that this series tries to solve.

The failure path of copying table still needs some improvement. At least
the pages allocated for root/context tables should be freed in the
failure path. Even worse, the software occupied a bit of page table
entry which is feasible for the old ECS, but not work for the new
scalable mode anymore.

All these problems deserve a separate series. We could address your
concerns there. Does this work for you?

Best regards,
iommu mailing list

Reply via email to