Tuomo Valkonen writes:
This release is finally what can be called "Ion 2 release candidate #1".

OK, I've it's up-and-runing on my machine. A few comments:


1. There's a bug in the autoconf script (my fault). With --disable-xinerama, -lXext is not added to LIBS and linking fails later (at runtime, due to not finding XShapeQueryExtension in dock.so). The attached patch fixes this.

2. Some of the config files still refer to ioncore*.lua in comments. Use grep.

3. Minor typo in README (system.mk, not ssystem.mk).

4. system.mk says libtool >= 1.4.0 is required, but README says libtool >= 1.4.3 is required. Which is it?

5; README and README.autoconf should be merged into a single file, or possibly separated into README and INSTALL with suitable changes. README.autoconf was written for when the autoconf script wasn't part of the ion distribution.


About the version numbering scheme:

I would like to see:
ion2-<date>
and the binaries, directory names, etc. similarly named. Currently the config directory is called ~/.ion2, but everything else is called ion. Renaming everything to ion2 would be consistent, and theoretically allow ion2 and the old ion stable (which some people still use) to be installed on the same machine without conflict.


Finally, is there any reason why the dock module is not automatically loaded in ion? (It is in pvm). How about adding include("dock-draw.lua") to the example look-*.lua files? Doing so would not harm non-dock users?

Cheers,

Tom
Index: configure.ac
===================================================================
RCS file: /home/twp/cvsroot/twp/ion/ion-devel-autoconf/configure.ac,v
retrieving revision 1.16
diff -u -r1.16 configure.ac
--- configure.ac        14 Jan 2004 11:32:19 -0000      1.16
+++ configure.ac        18 Jan 2004 14:20:30 -0000
@@ -21,6 +21,11 @@
 dnl Checks for libraries. {{{
 AC_PATH_XTRA()
 test "${X_DISPLAY_MISSING+set}" == set && exit 1
+AC_CHECK_LIB([Xext],
+                        [XMissingExtension],
+                        [X_LIBS="$X_LIBS -lXext"],
+                        [exit 1],
+                        [$X_PRE_LIBS -lX11 $X_LIBS $X_EXTRA_LIBS])
 dnl }}}
 
 dnl XINERAMA_LIBS, _DCF_NO_XINERAMA {{{
@@ -33,11 +38,6 @@
                                                          [Disable Xinerama support])])
 
 if test "x$enable_xinerama" != xno; then
-       AC_CHECK_LIB([Xext],
-                                [XMissingExtension],
-                                [X_LIBS="$X_LIBS -lXext"],
-                                [exit 1],
-                                [$X_PRE_LIBS -lX11 $X_LIBS $X_EXTRA_LIBS])
        AC_CHECK_LIB([Xinerama],
                                 [XineramaQueryExtension],
                                 [XINERAMA_LIBS="-lXinerama"],

Reply via email to