On Tuesday 30 December 2014 04:52:33 ?? wrote:
> Dear all,
>
> I'm Chul Lee working on Security Group at Samsung.
>
> We have a plan to commit the bootstrap code this week.
> But I am not sure that we can freely commit or we need to follow some
> process? So, I would like to ask before commit.
> Is there a commit process for iotivity git?
>
> Please share the information required for the commit process.
Hello Chul Lee, welcome to iotivity
The process is that you need to upload it to Gerrit and wait for the reviews
of those with experience in the code you touched. Once they have feedback, you
should provide either justifications or an updated version of the change that
contains the requested changed. Once the Maintainer (or delegated sub-
maintainers, if any) are ok with it, they will give you a +2 so the change can
be merged in.
We also ask that any large changes be left open for a number of days for
others, besides the Maintainer, to be able to review and offer their feedback.
The bigger the change, the longer it should remain open for reviewing.
For that reason, if possible, it's often best to make a sequence of smaller
changes that can be reviewed individually than a large change. Not always, so
we'll leave that to your discretion.
For the actual procedures, please see the wiki:
https://wiki.iotivity.org/how_to_use_gerrit
https://wiki.iotivity.org/submitting_to_gerrit
https://wiki.iotivity.org/reviewing_patches
If you have any questions, please ask.
HTH
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
